1From 27b0cd89656d39266da7dcab7eb1812dcfc34192 Mon Sep 17 00:00:00 2001
2From: "Steven M. Schweda" <sms@antinode.info>
3Date: Sat, 15 Jun 2019 18:13:11 -0700
4Subject: [PATCH] Fix CVE-2014-9913, buffer overflow in unzip
5
6---
7 list.c | 13 ++++++++++++-
8 1 file changed, 12 insertions(+), 1 deletion(-)
9
10diff --git a/list.c b/list.c
11index 5de41e5..e488109 100644
12--- a/list.c
13+++ b/list.c
14@@ -339,7 +339,18 @@ int list_files(__G) /* return PK-type error code */
15 G.crec.compression_method == ENHDEFLATED) {
16 methbuf[5] = dtype[(G.crec.general_purpose_bit_flag>>1) & 3];
17 } else if (methnum >= NUM_METHODS) {
18- sprintf(&methbuf[4], "%03u", G.crec.compression_method);
19+ /* 2013-02-26 SMS.
20+ * http://sourceforge.net/p/infozip/bugs/27/ CVE-2014-9913.
21+ * Unexpectedly large compression methods overflow
22+ * &methbuf[]. Use the old, three-digit decimal format
23+ * for values which fit. Otherwise, sacrifice the
24+ * colon, and use four-digit hexadecimal.
25+ */
26+ if (G.crec.compression_method <= 999) {
27+ sprintf( &methbuf[ 4], "%03u", G.crec.compression_method);
28+ } else {
29+ sprintf( &methbuf[ 3], "%04X", G.crec.compression_method);
30+ }
31 }
32
33 #if 0 /* GRR/Euro: add this? */
34--
352.20.1
36