commit 4b2555c
wf
·
2026-05-12 17:13:34 +0000 UTC
parent 0d61ae7
Fix buffer size values in snprintf
2 files changed,
+9,
-9
+1,
-1
1@@ -177,7 +177,7 @@ ipc_handler(int fd, uint32_t mask, void *data) {
2
3 status s = cmd_handler[cmd](argv);
4 char answer[MAXSIZE];
5- snprintf(answer, MAXSIZE * sizeof(char), "%d %s", s.ok, s.msg);
6+ snprintf(answer, sizeof(answer), "%d %s", s.ok, s.msg);
7
8 if (send(afd, answer, strlen(answer), 0) == -1)
9 _wrn("couldn't send answer to client");
+8,
-8
1@@ -326,7 +326,7 @@ ipc_get_geometry(char **arg) {
2
3 struct swc_rectangle geom;
4 if (swc_window_get_geometry(c->win, &geom)) {
5- snprintf(s.msg, MAXSIZE * sizeof(char), "%d %d %" PRIu32 " %" PRIu32 "\n", geom.x, geom.y, geom.width, geom.height);
6+ snprintf(s.msg, sizeof(s.msg), "%d %d %" PRIu32 " %" PRIu32 "\n", geom.x, geom.y, geom.width, geom.height);
7 }
8
9 s.ok = true;
10@@ -340,7 +340,7 @@ ipc_get_pid(char **arg) {
11 ARG_CLIENT(arg[1]);
12
13 pid_t pid = swc_window_get_pid(c->win);
14- snprintf(s.msg, MAXSIZE * sizeof(char), "%d\n", pid);
15+ snprintf(s.msg, sizeof(s.msg), "%d\n", pid);
16
17 s.ok = true;
18 return s;
19@@ -352,7 +352,7 @@ ipc_get_title(char **arg) {
20
21 ARG_CLIENT(arg[1]);
22
23- snprintf(s.msg, MAXSIZE * sizeof(char), "%s\n", c->win->title);
24+ snprintf(s.msg, sizeof(s.msg), "%s\n", c->win->title);
25
26 s.ok = true;
27 return s;
28@@ -364,7 +364,7 @@ ipc_get_app_id(char **arg) {
29
30 ARG_CLIENT(arg[1]);
31
32- snprintf(s.msg, MAXSIZE * sizeof(char), "%s\n", c->win->app_id);
33+ snprintf(s.msg, sizeof(s.msg), "%s\n", c->win->app_id);
34
35 s.ok = true;
36 return s;
37@@ -374,7 +374,7 @@ status
38 ipc_get_focus(char **arg) {
39 status s = {0};
40
41- snprintf(s.msg, MAXSIZE * sizeof(char), "%" PRIu32 "\n", wm.cur->id);
42+ snprintf(s.msg, sizeof(s.msg), "%" PRIu32 "\n", wm.cur->id);
43
44 s.ok = true;
45 return s;
46@@ -384,7 +384,7 @@ status
47 ipc_get_workspace(char **arg) {
48 status s = {0};
49
50- snprintf(s.msg, MAXSIZE * sizeof(char), "%d\n", wm.ws);
51+ snprintf(s.msg, sizeof(s.msg), "%d\n", wm.ws);
52
53 s.ok = true;
54 return s;
55@@ -454,7 +454,7 @@ ipc_get_screen_geometry(char **arg) {
56 if (!wm.scr)
57 return (status){ false, "" };
58
59- snprintf(s.msg, MAXSIZE * sizeof(char), "%" PRIu32 " %" PRIu32 "\n", wm.scr->width, wm.scr->height);
60+ snprintf(s.msg, sizeof(s.msg), "%" PRIu32 " %" PRIu32 "\n", wm.scr->width, wm.scr->height);
61
62 s.ok = true;
63 return s;
64@@ -466,7 +466,7 @@ ipc_get_cursor_position(char **arg) {
65
66 int32_t cx = 0, cy = 0;
67 if (swc_cursor_position(&cx, &cy))
68- snprintf(s.msg, MAXSIZE * sizeof(char), "%d %d\n", cx / 256, cy / 256);
69+ snprintf(s.msg, sizeof(s.msg), "%d %d\n", cx / 256, cy / 256);
70
71 s.ok = true;
72 return s;